Re: [PATCH v2 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

[Wolfram Sang <wsa@xxxxxxxxxxxxx>]

Hi Chris,

> +	struct clk *clk2;

I'd vote for 'clk_cd' since we are explicitly requesting that clock for
it.

> +	ret = clk_prepare_enable(priv->clk2);
> +	if (ret < 0)
> +		return ret;

You need to disable clk when failing.

Regards,

   Wolfram