On 12/21, Chris Brandt wrote: > On December 21, 2016, Geert Uytterhoeven wrote: > > >> Mike/Stephen: as this is a fix for stable (v3.16+), can you please > > >> take it directly? > > > > > > Sure, is it a fix for something that has been exposed as a problem in > > > this merge window? Just trying to gauge the urgency of merging this. > > > > No, I don't think it has been exposed by changes in this merge window (the > > only RZ/A1 changes were the enablement of SDHI and MMC). > > Chris, can you please confirm? > > That's correct. In reality, none of the existing RZ/A1 drivers in the kernel > should have ever worked (ETH, SPI, I2C, MTU2, etc...) because on chip reset > all the peripheral clocks are turned off. > > However...like Geert mentioned...the boot loader was turning everything on > shortly after reset so even though the clock driver never worked, it made > it seems so. Oops. > > Of course now going forward, I use a modified boot loader to turn everything > back off (except the serial console) so I can confirm that clock gating is > really working. > Ok, it seems like a more urgent fix due to the fact that the bootloader update has caused the drivers to stop working. I'll make sure to send it as a fix this release cycle. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
