Hi Stephen, On Tue, Dec 20, 2016 at 11:55 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 12/19, Geert Uytterhoeven wrote: >> On Thu, Dec 15, 2016 at 6:00 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote: >> > The RZ/A1 is different than the other Renesas SOCs because the MSTP >> > registers are 8-bit instead of 32-bit and if you try writing values as >> > 32-bit nothing happens...meaning this driver never worked for r7s72100. >> >> Thanks for your patch! >> >> The only reason it ever worked was that almost all module clocks are >> enabled at boot time... >> >> > Fixes: b6face404f38 ("ARM: shmobile: r7s72100: add essential clock nodes to dtsi") >> > Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx> >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> >> Mike/Stephen: as this is a fix for stable (v3.16+), can you please take it >> directly? > > Sure, is it a fix for something that has been exposed as a > problem in this merge window? Just trying to gauge the urgency of > merging this. No, I don't think it has been exposed by changes in this merge window (the only RZ/A1 changes were the enablement of SDHI and MMC). Chris, can you please confirm? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds