On Thu, Nov 3, 2016 at 4:34 PM, Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > Always stating PIN_CONFIG_BIAS_DISABLE is supported gives untrue output > when examining /sys/kernel/debug/pinctrl/e6060000.pfc/pinconf-pins if > the operation get_bias() are implemented but the pin are not handled by is implemented is not handled > the get_bias() implementation. In that case the output will state that > "input bias disabled" indicating that this pin have bias control has > support. > > Make support for PIN_CONFIG_BIAS_DISABLE depend on that the pin either > support SH_PFC_PIN_CFG_PULL_UP or SH_PFC_PIN_CFG_PULL_DOWN. This also supports > solves the issue where SoC specific implementations print error messages > if there particular implementation of {set,get}_bias() is called with a their > pin it do not know about. does > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds