Hi Sergei,
On Mon, Mar 7, 2016 at 10:19 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 03/08/2016 12:00 AM, Geert Uytterhoeven wrote:
>>>>>>> --- a/drivers/pinctrl/sh-pfc/core.c
>>>>>>> +++ b/drivers/pinctrl/sh-pfc/core.c
>>>>>>> @@ -545,7 +545,9 @@ static int sh_pfc_probe(struct platform_device
>>>>>>> *pdev)
>>>>>>> return ret;
>>>>>>> }
>>>>>>>
>>>>>>> - pinctrl_provide_dummies();
>>>>>>> + /* Enable dummy states for those platforms without pinctrl
>>>>>>> support */
>>>>>>> + if (!of_have_populated_dt())
>>>>>
>>>>>
>>>>>
>>>>> I'd considered this condition -- it won't fly on SH where
>>>>> CONFIG_OF=n,
>>>>> the kernel just won't build IIUC...
>>>>
>>>> I haven't tried to compile it yet, but <linux/of.h> does provide a dummy
>>>> that
>>>> returns false.
>>>
>>> Oops, indeed. I missed it. :-(
>>> This approach is better then, won't have to fix again whenever SH
>>> gets DT
>>> support.
>
>> Perhaps the of_have_populated_dt() check should be moved inside
>> pinctrl_provide_dummies()?
>
> That's probably a good idea...
>
>> Besides omap2, which has its own check, the only other user is imx1.
>
> i.MX2x/3x as well, no?
Yeah sorry, several i.MX. I accidentally typed a trailing "1".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
