> Subject: Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for
> i.MX8M
>
> Good morning,
>
> On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > The DDR Alias address should be 0x40000000 according to RM, so
> correct
> > it.
> >
> > Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M")
>
> This commit was merged more than 3 years ago... I don't see how such
> a blatant mistake could have survived this long without causing
> problems or being noticed.
I got this reported quite sometime ago inside NXP. For community
users, not sure people encounter issue or not.
I am trying to upstream downstream patches, so post this out.
> On top of things checkpatch gives me a warning.
The warning could ignored.
There is no public url for reporting this issue.
>
> > Reported-by: Terry Lv <terry.lv@xxxxxxx>
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > ---
> > drivers/remoteproc/imx_rproc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index
> 144c8e9a642e..3c8b64db8823
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -210,7 +210,7 @@ static const struct imx_rproc_att
> imx_rproc_att_imx8mq[] = {
> > /* QSPI Code - alias */
> > { 0x08000000, 0x08000000, 0x08000000, 0 },
> > /* DDR (Code) - alias */
> > - { 0x10000000, 0x80000000, 0x0FFE0000, 0 },
> > + { 0x10000000, 0x40000000, 0x0FFE0000, 0 },
>
> Without access to HW or the documentation there is no way for me to
> assess the validity of this patch. Marek, Iuliana and Daniel - please
> review and test this patch.
I see Iuliana gaves R-b and doc link.
Thanks,
Peng.
>
> Thanks,
> Mathieu
>
> > /* TCML */
> > { 0x1FFE0000, 0x007E0000, 0x00020000, ATT_OWN |
> ATT_IOMEM},
> > /* TCMU */
> >
> > --
> > 2.37.1
> >
