> Subject: Re: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue > earlier > > On Fri, Jul 12, 2024 at 04:34:56PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@xxxxxxx> > > > > Initialize workqueue before requesting mailbox channel, otherwise if > > mailbox interrupt comes before workqueue ready, the > > imx_rproc_rx_callback will trigger issue. > > > > Reviewed-by: Richard Zhu <hongxing.zhu@xxxxxxx> > > All reviews should be done publicly - please remove here and for all the > other patches. Sure. > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > > --- > > drivers/remoteproc/imx_rproc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index > 48c48b53a3aa..9e99bb27c033 > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -1087,6 +1087,8 @@ static int imx_rproc_probe(struct > platform_device *pdev) > > return -ENOMEM; > > } > > > > + INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > > + > > There should be a "Fixes:" tag on this patch. Add in v2. Thanks, Peng.
