Hi Markus, On Fri, Apr 17, 2020 at 05:48:49PM +0200, Markus Elfring wrote: > >> p = firmware ? kstrdup_const(…) : kasprintf(…); > > > > For simple assignments, I too prefer the ternary operator, > > Thanks for your feedback. > > > > but in this case, I think it is better to leave the current code as is. > > Would you like to consider the use of the function “kvasprintf_const” > according to your review comment for the update step “[PATCH v2 4/7] remoteproc: > Use kstrdup_const() rather than kstrup()”? > Looking at the implementation of kvasprintf_const(), using it here wouldn't give us anything. Indeed allocation of duplicate memory is avoided only if the string is pre determined of if it is exactly %s, which isn't the case here. Otherwise things default to kvasprintf(). Thanks, Mathieu > Regards, > Markus
