>> p = firmware ? kstrdup_const(…) : kasprintf(…); > > For simple assignments, I too prefer the ternary operator, Thanks for your feedback. > but in this case, I think it is better to leave the current code as is. Would you like to consider the use of the function “kvasprintf_const” according to your review comment for the update step “[PATCH v2 4/7] remoteproc: Use kstrdup_const() rather than kstrup()”? Regards, Markus