On 4/17/20 10:48 AM, Markus Elfring wrote:
p = firmware ? kstrdup_const(…) : kasprintf(…);
For simple assignments, I too prefer the ternary operator,
Thanks for your feedback.
but in this case, I think it is better to leave the current code as is.
Would you like to consider the use of the function “kvasprintf_const”
according to your review comment for the update step “[PATCH v2 4/7] remoteproc:
Use kstrdup_const() rather than kstrup()”?
This patch is just swapping the condition order, so will automatically
be adjusted for any changes in patch 4 during the rebase.
regards
Suman