On Tue, Sep 22, 2020 at 08:30:03PM -0300, Jason Gunthorpe wrote:
> On Tue, Sep 22, 2020 at 04:44:29PM +0300, Kamal Heib wrote:
> > The proper return code is "-EOPNOTSUPP" when trying to modify a raw
> > packet QP over an IB port.
> >
> > Fixes: 3987a2d3193c ("IB/mlx4: Add raw packet QP support")
> > Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
> > ---
> > drivers/infiniband/hw/mlx4/qp.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Is it? Why? EOPNOTSUPP should be used by the uverbs layer to indicate
> that the operation is not implemented in the driver
>
> Calling modify_qp against a RAW_QP when it is not supported by spec is
> EINVAL?
>
> Jason
Please drop this patch...
The idea behind it was to avoid the pyverbs test_qp.py failure when trying
to create a RAW QP over an mlx4 IB port, this was fixed using the
following change in the test_qp.py:
https://github.com/linux-rdma/rdma-core/pull/833
Thanks,
Kamal
