Re: [PATCH for-rc] RDMA/mlx4: Fix return value when QP type isn't supported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 22, 2020 at 04:44:29PM +0300, Kamal Heib wrote:
> The proper return code is "-EOPNOTSUPP" when trying to modify a raw
> packet QP over an IB port.
> 
> Fixes: 3987a2d3193c ("IB/mlx4: Add raw packet QP support")
> Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
> ---
>  drivers/infiniband/hw/mlx4/qp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Is it? Why? EOPNOTSUPP should be used by the uverbs layer to indicate
that the operation is not implemented in the driver

Calling modify_qp against a RAW_QP when it is not supported by spec is
EINVAL?

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux