On Fri, Sep 25, 2020 at 11:49:13AM -0500, Gustavo A. R. Silva wrote: > Calls to kzalloc() and kvzalloc() should be null-checked > in order to avoid any potential failures. In this case, > a potential null pointer dereference. > > Fix this by adding null checks for _parse_attr_ and _flow_ > right after allocation. > > Addresses-Coverity-ID: 1497154 ("Dereference before null check") > Fixes: c620b772152b ("net/mlx5: Refactor tc flow attributes structure") > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>