Re: [PATCH rdma-next 2/4] IB/core: Enable ODP sync without faulting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 16, 2020 at 09:19:11PM +0300, Leon Romanovsky wrote:
> On Wed, Sep 16, 2020 at 05:47:06PM +0100, Christoph Hellwig wrote:
> > > +		if (fault) {
> > > +			/*
> > > +			 * Since we asked for hmm_range_fault() to populate pages,
> >
> > Totally pointless line over 80 characters.
> 
> checkpatch.pl was updated to allow 100 symbols.

checkpatch.pl doesn't matter, it is in fact pretty silly.  The coding
style document says:

"The preferred limit on the length of a single line is 80 columns.

Statements longer than 80 columns should be broken into sensible chunks,
unless exceeding 80 columns significantly increases readability and does
not hide information."

and that absolutely is not the case here, you could trivially move the
last word into the next line and would not even increase the line count.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux