On Wed, Sep 16, 2020 at 05:47:06PM +0100, Christoph Hellwig wrote:
> > + if (fault) {
> > + /*
> > + * Since we asked for hmm_range_fault() to populate pages,
>
> Totally pointless line over 80 characters.
checkpatch.pl was updated to allow 100 symbols.
Regarding "pointless", at least for me it wasn't clear why we don't
have HMM_PFN_ERROR check in non-fault path so I asked form Yishai to
add this comment.
>
> > + access_mask = (range.hmm_pfns[pfn_index] & HMM_PFN_WRITE) ?
> > + (ODP_READ_ALLOWED_BIT | ODP_WRITE_ALLOWED_BIT) :
> > + ODP_READ_ALLOWED_BIT;
> > + }
>
> Another weird overly long line, caused by rather osfucated code. This
> really should be something like:
>
> access_mask = ODP_READ_ALLOWED_BIT;
> if (range.hmm_pfns[pfn_index] & HMM_PFN_WRITE)
> access_mask |= ODP_WRITE_ALLOWED_BIT;
Sure
>
