Re: [PATCH rdma-next 2/4] IB/core: Enable ODP sync without faulting

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

> +		if (fault) {
> +			/*
> +			 * Since we asked for hmm_range_fault() to populate pages,

Totally pointless line over 80 characters.

> +			access_mask = (range.hmm_pfns[pfn_index] & HMM_PFN_WRITE) ?
> +				(ODP_READ_ALLOWED_BIT | ODP_WRITE_ALLOWED_BIT) :
> +				 ODP_READ_ALLOWED_BIT;
> +		}

Another weird overly long line, caused by rather osfucated code.  This
really should be something like:

			access_mask = ODP_READ_ALLOWED_BIT;
			if (range.hmm_pfns[pfn_index] & HMM_PFN_WRITE)
				access_mask |= ODP_WRITE_ALLOWED_BIT;