On Wed, Nov 20, 2019 at 7:02 PM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > > On Wed, Nov 20, 2019 at 10:52:01AM +0530, Devesh Sharma wrote: > > On Wed, Nov 20, 2019 at 1:08 AM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > > > > > > On Tue, Nov 19, 2019 at 10:48:48AM -0500, Devesh Sharma wrote: > > > > This series contain 3 patches patch 1 and patch 2 are specific to > > > > Gen P5 devices. Patch 3 is a generic fix to silence few sparse > > > > warnings. > > > > > > These commit messages are not suitable for -rc, and a sparse warning > > > fix is rarely appropriate > > > > > > You need to describe what the user impact is of these bugs. > > > > > > -rc is done anyhow unless something urgent comes up. > > Got your point. Let's drop sparse fixes patch from this series. > > Why? it can go to -next, like I said, there won't be another -rc Yup, it can certainly go. > > > For first patch the impact catastrophic as consumer wont be able to use the > > cards as it won't be listed the dev_list. > > Supporting a new card is a new feature, not -rc material Alright, I shall move the series to for-next and add back the sparse warning fix. Please ignore V2 which have posted already. > > Jason
