Re: [PATCH net] net: rtnetlink: prevent underflows in do_setvfinfo()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/20/19 5:34 AM, Dan Carpenter wrote:
> I reported this bug to the linux-rdma mailing list in April and this
> patch wasn't considered very elegant.  I can see how that's true.  The
> developer offered to write a fix which would update all the drivers to
> use u32 throughout.  I reminded him in September that this bug still
> needs to be fixed.

Since the uapi (ifla_vf_mac, ifla_vf_vlan, ...) all have u32, I agree
with that comment -- it seems like the ndo functions should be changed
from 'int vf' to 'u32 vf'.



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux