On Wed, Nov 20, 2019 at 1:08 AM Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > > On Tue, Nov 19, 2019 at 10:48:48AM -0500, Devesh Sharma wrote: > > This series contain 3 patches patch 1 and patch 2 are specific to > > Gen P5 devices. Patch 3 is a generic fix to silence few sparse > > warnings. > > These commit messages are not suitable for -rc, and a sparse warning > fix is rarely appropriate > > You need to describe what the user impact is of these bugs. > > -rc is done anyhow unless something urgent comes up. Got your point. Let's drop sparse fixes patch from this series. For first patch the impact catastrophic as consumer wont be able to use the cards as it won't be listed the dev_list. For second patch the impact is that the end-user won't be able to read the hardware stats. Let me add both points in the commit description respectively. > > Jason
