Re: [PATCH rdma-core 2/2] cxgb4: remove unused c4iw_match_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-08-06 at 14:13 +0300, Leon Romanovsky wrote:
> On Tue, Aug 06, 2019 at 04:38:13PM +0530, Potnuri Bharat Teja wrote:
> > On Tuesday, August 08/06/19, 2019 at 15:18:49 +0530, Leon Romanovsky
> > wrote:
> > > On Tue, Aug 06, 2019 at 11:09:02AM +0300, Leon Romanovsky wrote:
> > > > On Mon, Aug 05, 2019 at 04:36:53PM +0530, Potnuri Bharat Teja
> > > > wrote:
> > > > > On Monday, July 07/29/19, 2019 at 13:16:20 +0530, Potnuri
> > > > > Bharat Teja wrote:
> > > > > > On Sunday, July 07/28/19, 2019 at 14:07:49 +0530, Leon
> > > > > > Romanovsky wrote:
> > > > > > > On Thu, Jul 25, 2019 at 03:14:24PM -0300, Jason Gunthorpe
> > > > > > > wrote:
> > > > > > > > On Thu, Jul 25, 2019 at 11:19:28PM +0530, Potnuri Bharat
> > > > > > > > Teja wrote:
> > > > > > > > > match_device handler is no longer needed after latest
> > > > > > > > > device binding changes.
> > > > > > > > > 
> > > > > > > > > Signed-off-by: Potnuri Bharat Teja <bharat@xxxxxxxxxxx
> > > > > > > > > >
> > > > > > > > > ---
> > > > > > > > >  providers/cxgb4/dev.c | 41 --------------------------
> > > > > > > > > ---------------
> > > > > > > > >  1 file changed, 41 deletions(-)
> > > > > > > > 
> > > > > > > > Do you know if we can also drop the same code in cxgb3?
> > > > > > > 
> > > > > > > Can we simply remove cxgb3?
> > > > > > > 
> > > > > > 
> > > > > > I am in talks with the people here. I'll confirm it soon.
> > > > > 
> > > > > Hi Jason/Doug/Leon,
> > > > > Chelsio is fine with removing cxgb3.
> > > > 
> > > > Thanks a lot.
> > > 
> > > Which parts of cxgb3 can we remove? RDMA, scsi, net or everything?
> > 
> > I can only say RDMA. For net and scsi parts of cxgb3, the
> > corresponding
> > maintainers might request for their removal.
> > Should I send a patch removing RDMA cxgb3?
> 
> It will be the best variant.
> 
> Thanks
> 
> > Thanks.

I'm not entirely sure that I want it removed yet.  The cxgb3 isn't the
most stellar device, but it will do 40GBit/s.  That's still a very
respectable speed (unlike say mthca that was mostly 10GBit/s with only a
short run of 20GBit/s devices before it switched over to mlx4).  So a
cxgb3 based home system is still something very usable.  Are we sure we
want to remove this?

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux