On Tue, Aug 06, 2019 at 02:53:49PM +0000, Bernard Metzler wrote: > >> index 7de68f1dc707..af735f55b291 100644 > >> +++ b/include/uapi/rdma/siw-abi.h > >> @@ -180,6 +180,7 @@ struct siw_cqe { > >> * to control CQ arming. > >> */ > >> struct siw_cq_ctrl { > >> - __aligned_u64 notify; > >> + __u32 flags; > >> + __u32 pad; > > > >The commit message needs to explain why this is compatible with > >existing user space, if it is even is safe.. > > > Old libsiw would remain compatible with the new layout, since it > simply reads the 32bit 'flags' and zeroed 32bit 'pad' into a 64bit > 'notify', ending with reading the same bits. Even on big endian? Jason