On Tue, Mar 05, 2019 at 11:05:05AM +0200, Leon Romanovsky wrote: > On Mon, Mar 04, 2019 at 04:13:53PM -0400, Jason Gunthorpe wrote: > > On Mon, Mar 04, 2019 at 09:52:39PM +0200, Leon Romanovsky wrote: > > > > > > In each of these branches? Only one can run, right? > > > > > > I don't like "else if ()" construction and see it is as dangerous, due > > > to the fact that it hides code flow. I intentionally avoid "else if" in > > > my patches. > > > > Oh, I don't think that is a good idea, if the control can only do one > > of the ifs it should be explicit through return/goto/else/etc. > > > > Otherwise it looks like all the ifs can run concurrently, which is not > > at all the case. > > I didn't want to see goto in the middle of flow just to jump over some ifs. This is why else exists. Jason
