Re: [PATCH rdma-next v1] RDMA/mlx5: Clean WQE page fault handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 04, 2019 at 09:52:39PM +0200, Leon Romanovsky wrote:

> > In each of these branches? Only one can run, right?
> 
> I don't like "else if ()" construction and see it is as dangerous, due
> to the fact that it hides code flow. I intentionally avoid "else if" in
> my patches.

Oh, I don't think that is a good idea, if the control can only do one
of the ifs it should be explicit through return/goto/else/etc.

Otherwise it looks like all the ifs can run concurrently, which is not
at all the case.

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux