On Tue, 2019-02-05 at 14:56 +-0000, Israel Rukshin wrote: +AD4 On 2/5/2019 6:25 AM, Bart Van Assche wrote: +AD4 +AD4 On 2/4/19 9:50 AM, Max Gurtovoy wrote: +AD4 +AD4 +AD4 +-+ACM-include +ADw-rdma/signature.h+AD4 +AD4 +AD4 +AD4 +AD4 Do we really need this +ACM-include directive in +ADw-rdma/ib+AF8-verbs.h+AD4? Can +AD4 +AD4 this +ACM-include directive be moved into the source files that need it? +AD4 +AD4 Yes, we need this include at +ADw-rdma/ib+AF8-verbs.h+AD4. +AD4 +AD4 +ADw-rdma/ib+AF8-verbs.h+AD4 uses struct ib+AF8-sig+AF8-err which is defined at +AD4 +ADw-rdma/signature.h+AD4. Hi Israel, Are you perhaps referring to struct ib+AF8-mr+AF8-status? It seems to me that that structure is only used in code that is related to protection information. Have you considered to move the definition of that structure into +ADw-rdma/signature.h+AD4 and add a forward declaration of that structure in +ADw-rdma/ib+AF8-verbs.h+AD4 instead? Thanks, Bart.
