On 2/5/2019 6:25 AM, Bart Van Assche wrote: > On 2/4/19 9:50 AM, Max Gurtovoy wrote: >> +#include <rdma/signature.h> > > Do we really need this #include directive in <rdma/ib_verbs.h>? Can > this #include directive be moved into the source files that need it? > > Thanks, > > Bart. Yes, we need this include at <rdma/ib_verbs.h>. <rdma/ib_verbs.h> uses struct ib_sig_err which is defined at <rdma/signature.h>. Thanks, Israel