On 1/22/19 11:31 AM, Leon Romanovsky wrote: > +static const > +struct filters pd_valid_filters[MAX_NUMBER_OF_FILTERS] = { > + { .name = "dev", .is_number = false }, > + { .name = "users", .is_number = true }, > + { .name = "pid", .is_number = true }, > + { .name = "ctxn", .is_number = true }, > + { .name = "pdn", .is_number = true }, > + { .name = "ctxn", .is_number = true } > +}; These should not be in a header file. Looks like you have done this in other patches as well.