On Fri, Jan 25, 2019 at 10:19:22AM -0700, David Ahern wrote:
> On 1/22/19 11:31 AM, Leon Romanovsky wrote:
> > +static const
> > +struct filters pd_valid_filters[MAX_NUMBER_OF_FILTERS] = {
> > + { .name = "dev", .is_number = false },
> > + { .name = "users", .is_number = true },
> > + { .name = "pid", .is_number = true },
> > + { .name = "ctxn", .is_number = true },
> > + { .name = "pdn", .is_number = true },
> > + { .name = "ctxn", .is_number = true }
> > +};
>
> These should not be in a header file. Looks like you have done this in
> other patches as well.
This is the outcome of how we build command line with single struct *rd,
see res_show(). While I refactored the code, I saw your comment is coming,
but decided to proceed anyway to make this series a little bit sane.
I'll definitely continue to refactor it, but for now, there is a need to see
valid_filters structure in RES_FUNC() macro.
Thanks
Attachment:
signature.asc
Description: PGP signature
