On 04-Dec-18 18:02, Jason Gunthorpe wrote:
> On Tue, Dec 04, 2018 at 02:04:24PM +0200, Gal Pressman wrote:
>
>> + if (unlikely(read_resp->req_id != mmio_read->seq_num)) {
>> + pr_err("Reading register timed out. expected: req id[%u] offset[%#x] actual: req id[%u] offset[%#x]\n",
>> + mmio_read->seq_num, offset, read_resp->req_id,
>> + read_resp->reg_off);
>
> every use of pr_err/pr_debug/etc I saw should be a
> dev_err/dev/debug/etc in this driver.
Will change.
>
>> + pr_debug("init cq dma_addr....\n");
>
> Please don't upstream so many wonky pr_debugs...
ACK, I'll keep the meaningful prints only.
>
> Jason
>
