On 04-Dec-18 18:01, Jason Gunthorpe wrote:
> On Tue, Dec 04, 2018 at 02:04:23PM +0200, Gal Pressman wrote:
>> Add the EFA ABI file.
>>
>> Signed-off-by: Gal Pressman <galpress@xxxxxxxxxx>
>> include/uapi/rdma/efa-abi.h | 89 +++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 89 insertions(+)
>> create mode 100644 include/uapi/rdma/efa-abi.h
>>
>> diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h
>> new file mode 100644
>> index 000000000000..0f97a0fba967
>> +++ b/include/uapi/rdma/efa-abi.h
>> @@ -0,0 +1,89 @@
>> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
>> +/*
>> + * Copyright 2018 Amazon.com, Inc. or its affiliates.
>> + */
>> +
>> +#ifndef _EFA_ABI_H_
>> +#define _EFA_ABI_H_
>> +
>> +enum efa_ibv_user_cmds_supp_udata {
>> + EFA_USER_CMDS_SUPP_UDATA_QUERY_DEVICE = 1 << 0,
>> + EFA_USER_CMDS_SUPP_UDATA_CREATE_AH = 1 << 1,
>> +};
>> +
>> +enum efa_ibv_kernel_supp_mask {
>> + EFA_KERNEL_SUPP_QPT_SRD = 1 << 0,
>> +};
>> +
>> +struct efa_ibv_alloc_ucontext_resp {
>> + __u32 comp_mask;
>> + __u32 cmds_supp_udata_mask;
>> + __u32 kernel_supp_mask;
>> + __u8 reserved_60[0x4];
>
> The use of _60 is a bit non-conventional for these headers, the
> trailing reserved should usually just be reserved..
>
> Jason
>
The _60 states the offset of the field inside the struct, makes it more readable
than having a plain reserved.
