Re: [PATCH rdma-next 08/13] RDMA/efa: Implement functions that submit and complete admin commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 04, 2018 at 02:04:24PM +0200, Gal Pressman wrote:

> +	if (unlikely(read_resp->req_id != mmio_read->seq_num)) {
> +		pr_err("Reading register timed out. expected: req id[%u] offset[%#x] actual: req id[%u] offset[%#x]\n",
> +		       mmio_read->seq_num, offset, read_resp->req_id,
> +		       read_resp->reg_off);

every use of pr_err/pr_debug/etc I saw should be a
dev_err/dev/debug/etc in this driver.

> +	pr_debug("init cq dma_addr....\n");

Please don't upstream so many wonky pr_debugs...

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux