Re: [PATCH v3 1/2] RDMA/Core: add RDMA_NLDEV_CMD_NEWLINK/DELLINK support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 30, 2018 at 02:18:00PM -0600, Steve Wise wrote:
> 
> 
> On 11/30/2018 2:12 PM, Jason Gunthorpe wrote:
> > On Fri, Nov 30, 2018 at 02:07:52PM -0600, Steve Wise wrote:
> >
> >> So perhaps nldev_dellink() should just lookup the ib_device by index
> >> using ib_device_get_by_index(), note the device name (copy it
> >> locally)
> > That just creates races with rename.
> >
> > The API to the driver should be pointer based and has to hold only the
> > kref not the refcnt 
> >
> > Jason
> 
> What kref?  I don't see any kref in struct ib_device.  /me confused...

It is inside the embedded struct device

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux