Re: [PATCH v3 1/2] RDMA/Core: add RDMA_NLDEV_CMD_NEWLINK/DELLINK support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 30, 2018 at 01:29:22AM +0000, Ruhl, Michael J wrote:

> Should the mutex be held while calling the callback?  If the newlink or dellink
> callbacks need to sleep (probably dellink specifically), I think holding the mutex
> might not be a good idea.

It would be a bit better if this lock was a rwsem, but it must be held
whenever ops is touched.. This is probably a moot point though when
dellink goes through the ib_dev not the ops list..

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux