On 11/30/2018 2:12 PM, Jason Gunthorpe wrote: > On Fri, Nov 30, 2018 at 02:07:52PM -0600, Steve Wise wrote: > >> So perhaps nldev_dellink() should just lookup the ib_device by index >> using ib_device_get_by_index(), note the device name (copy it >> locally) > That just creates races with rename. > > The API to the driver should be pointer based and has to hold only the > kref not the refcnt > > Jason What kref? I don't see any kref in struct ib_device. /me confused... Steve