RE: [PATCH rdma-next 07/12] RDMA: Use ib_gid_attr in query attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Jason Gunthorpe [mailto:jgg@xxxxxxxx]
> Sent: Wednesday, May 16, 2018 4:18 PM
> To: Leon Romanovsky <leon@xxxxxxxxxx>
> Cc: Doug Ledford <dledford@xxxxxxxxxx>; Leon Romanovsky
> <leonro@xxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>;
> Parav Pandit <parav@xxxxxxxxxxxx>
> Subject: Re: [PATCH rdma-next 07/12] RDMA: Use ib_gid_attr in query attributes
> 
> On Mon, May 14, 2018 at 11:11:13AM +0300, Leon Romanovsky wrote:
> 
> > @@ -506,42 +506,30 @@ EXPORT_SYMBOL(ib_get_gids_from_rdma_hdr);
> >   * ah_attribute must have have valid port_num, sgid_index.
> >   */
> >  static int ib_resolve_unicast_gid_dmac(struct ib_device *device,
> > -				       struct rdma_ah_attr *ah_attr)
> > +				       struct rdma_ah_attr *ah_attr,
> > +				       const union ib_gid *sgid,
> > +				       const struct ib_gid_attr *sgid_attr)
> 
> I think it is strange to pass around sgid and sgid_attrs.
> 
> Why doesn't sgid_attrs contain the gid as well? Seems broadly wrong not to do
> that.
It doesn't look wrong to me. It is just less optimal.
I am enhancing this in v1.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux