On Mon, May 14, 2018 at 11:11:13AM +0300, Leon Romanovsky wrote: > @@ -506,42 +506,30 @@ EXPORT_SYMBOL(ib_get_gids_from_rdma_hdr); > * ah_attribute must have have valid port_num, sgid_index. > */ > static int ib_resolve_unicast_gid_dmac(struct ib_device *device, > - struct rdma_ah_attr *ah_attr) > + struct rdma_ah_attr *ah_attr, > + const union ib_gid *sgid, > + const struct ib_gid_attr *sgid_attr) I think it is strange to pass around sgid and sgid_attrs. Why doesn't sgid_attrs contain the gid as well? Seems broadly wrong not to do that. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
