On Wed, May 16, 2018 at 03:17:57PM -0600, Jason Gunthorpe wrote: > On Mon, May 14, 2018 at 11:11:13AM +0300, Leon Romanovsky wrote: > > > @@ -506,42 +506,30 @@ EXPORT_SYMBOL(ib_get_gids_from_rdma_hdr); > > * ah_attribute must have have valid port_num, sgid_index. > > */ > > static int ib_resolve_unicast_gid_dmac(struct ib_device *device, > > - struct rdma_ah_attr *ah_attr) > > + struct rdma_ah_attr *ah_attr, > > + const union ib_gid *sgid, > > + const struct ib_gid_attr *sgid_attr) > > I think it is strange to pass around sgid and sgid_attrs. > > Why doesn't sgid_attrs contain the gid as well? Seems broadly wrong > not to do that. You can ask the same question for many *_attr interfaces in our subsystem. For example, why isn't ib_qp connected to ib_qp_attr? Thanks > > Jason
Attachment:
signature.asc
Description: PGP signature
