RE: [PATCH 0/5] rdma/cxgb4: Add SRQ support for Chelsio adapters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Jason Gunthorpe <jgg@xxxxxxxx>
> Sent: Tuesday, March 13, 2018 9:24 AM
> To: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> Cc: 'Raju Rangoju' <rajur@xxxxxxxxxxx>; dledford@xxxxxxxxxx; linux-
> rdma@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 0/5] rdma/cxgb4: Add SRQ support for Chelsio adapters
> 
> On Mon, Mar 12, 2018 at 03:49:30PM -0500, Steve Wise wrote:
> > > > > There are a bunch of changes to the ethernet driver here..
> > > > >
> > > > > If we take this into the rdma tree you are guarenteeing there will
be
> > > > > no conflicts with anything going on with the ethernet side this
cycle?
> > > > >
> > > > > Would want DaveM's ack on the ethernet part, I think? Why didn't
> you
> > > > > CC netdev?
> > > > >
> > > > > Jason
> > > >
> > > > Hey Jason,  Yes, this series should CC netdev for sure.  Previously,
we
> > have
> > > > been able to pull these types of series' through either netdev or
> > linux-rdma
> > > > with the ACK from the other maintainer.
> > >
> > > We usually want to see these as pull requests if they really need to
> > > go to both trees.. Which means you need a k.o account, I think.
> > >
> > > uapi changes like this need to be explicitly acked by RDMA though.
> > >
> > > > I'm not sure how we "guarantee there will be no conflicts"?
> > >
> > > Don't send any patches to netdev that would conflict..
> >
> > So chelsio would get an account on k.o to stage this series.  Then ask
both
> > Dave and you/doug to pull the series (once reviewed and accepted) from
> a k.o
> > git tree.
> 
> If you are doing this often, and if it is typically at risk of making
> conflicts, then yes.
> 
> > And after that, any commits against cxgb4 and iw_cxgb4 submitted
> > by chelsio should be based on top of this series until it merges into
> > linus's tree.
> 
> You can do that, yes, or you can carefully manage what you sent to
> both trees to avoid overlap.
> 
> It really depends how much churn your driver is getting.
> 
> In this case, if you say you don't expect to create conflicts we can
> take this into RDMA without PRs, but we still need DaveM's ack.
> 
> Jason

Thanks Jason.  I would like to avoid the git repo.  So let me huddle up with
the chelsians and verify we can manage this one instance.   Also, Raju will
ensure that v2 of the series will CC Netdev and explicitly ask Dave for an
ACK.



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux