Re: [PATCH 0/5] rdma/cxgb4: Add SRQ support for Chelsio adapters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 12, 2018 at 01:45:36PM -0500, Steve Wise wrote:
> > 
> > On Mon, Mar 12, 2018 at 11:12:58PM +0530, Raju Rangoju wrote:
> > > Shared Receive Queues (SRQ) is a pool of receive buffers that allows
> multiple
> > QPs to share these buffers amongst them.
> > >
> > > This patch series adds the code changes to enable SRQ support for
> Chelsio
> > adapters.
> > >
> > > The following are the major changes.
> > > - Add cpl support for srq
> > > - Add srq debugfs support
> > > - Add SRQ FW query parameters
> > > - Add srq create/destroy/modify routines
> > > - Handle flushed SRQ buffers
> > >
> > > Raju Rangoju (5):
> > >   cxgb4: Adds CPL support for Shared Receive Queues
> > >   cxgb4: Add debugfs support for SRQ
> > >   cxgb4: Add support to query HW SRQ parameters
> > >   rdma/cxgb4: Add t4_srq support functions & structs
> > >   rdma/cxgb4: Add support for kernel mode srqs
> > >
> > >  drivers/infiniband/hw/cxgb4/cm.c                   |  40 +-
> > >  drivers/infiniband/hw/cxgb4/cq.c                   | 175 ++++-
> > >  drivers/infiniband/hw/cxgb4/device.c               |  18 +-
> > >  drivers/infiniband/hw/cxgb4/iw_cxgb4.h             |  41 +-
> > >  drivers/infiniband/hw/cxgb4/provider.c             |  10 +-
> > >  drivers/infiniband/hw/cxgb4/qp.c                   | 805
> +++++++++++++++++----
> > >  drivers/infiniband/hw/cxgb4/resource.c             |  50 +-
> > >  drivers/infiniband/hw/cxgb4/t4.h                   | 151 +++-
> > >  drivers/infiniband/hw/cxgb4/t4fw_ri_api.h          |  19 +
> > >  drivers/net/ethernet/chelsio/cxgb4/Makefile        |   2 +-
> > >  drivers/net/ethernet/chelsio/cxgb4/cxgb4.h         |   1 +
> > >  drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c |   2 +
> > >  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c    |  20 +
> > >  drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h     |   1 +
> > >  drivers/net/ethernet/chelsio/cxgb4/srq.c           | 230 ++++++
> > >  drivers/net/ethernet/chelsio/cxgb4/srq.h           |  71 ++
> > >  drivers/net/ethernet/chelsio/cxgb4/t4_msg.h        |  72 ++
> > >  drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h      |   2 +
> > >  include/uapi/rdma/cxgb4-abi.h                      |  18 +-
> > >  19 files changed, 1558 insertions(+), 170 deletions(-)
> > >  create mode 100644 drivers/net/ethernet/chelsio/cxgb4/srq.c
> > >  create mode 100644 drivers/net/ethernet/chelsio/cxgb4/srq.h
> > 
> > There are a bunch of changes to the ethernet driver here..
> > 
> > If we take this into the rdma tree you are guarenteeing there will be
> > no conflicts with anything going on with the ethernet side this cycle?
> > 
> > Would want DaveM's ack on the ethernet part, I think? Why didn't you
> > CC netdev?
> > 
> > Jason
> 
> Hey Jason,  Yes, this series should CC netdev for sure.  Previously, we have
> been able to pull these types of series' through either netdev or linux-rdma
> with the ACK from the other maintainer.

We usually want to see these as pull requests if they really need to
go to both trees.. Which means you need a k.o account, I think.

uapi changes like this need to be explicitly acked by RDMA though.
     
> I'm not sure how we "guarantee there will be no conflicts"?

Don't send any patches to netdev that would conflict..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux