RE: [PATCH v2 rdma-next 2/9] RDMA/CM: move rdma_id_private to cma_priv.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > >
> > > But, that's not it either.  Looking at this thread, the cover letter is
> > > from Steve at 2:15pm.  However, patch 2/9 is from Steve at 11:16am.  See
> > > for yourself:
> > >
> > > Cover Letter headers:
> > > From: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> > > Date: Mon, 19 Feb 2018 11:15:02 -0800 (02/19/2018 02:15:02 PM)
> > > Subject: [PATCH v2 rdma-next 0/9] cm_id, cq, mr, and pd resource
> > > tracking
> > >
> > > Patch 2/9 headers:
> > > From: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> > > Date: Mon, 19 Feb 2018 08:16:33 -0800 (02/19/2018 11:16:33 AM)
> > > Subject: [PATCH v2 rdma-next 2/9] RDMA/CM: move rdma_id_private to
> > > cma_priv.h
> > >
> > >
> > Oh I think I know what's happening.  I created these patches on a machine
> that is in PST timezone, and the clock on the system might not even be setup
> correctly.   I use git format-patch for that.  I then pull the patches to Texas
> (CST timezone) and submit them to my email server via sendmail.  So the
> "Date: " in the patch is from the PST patch creation time, and the "Received: "
> times logged by ogc are CST.
> >
> > Why is this confusing patchworks though?  If it uses the patch dates only or
> the received dates only, it should be in-order, I think.
> 
> Even that doesn't explain the above.  There are two vastly different
> timestamps on the emails.  Patchworks is evidently using the Date:
> header, and on the two different files coming from the computer in the
> PST timezone, the times are different by 3 hours.

I think the problem was caused by me using stg (Stacked Git), and perhaps how I rebased the series for the v2 submission.  The author dates in the git branch are screwed up.  

Here is the git log showing the author dates from the branch I used to generate the patches:

[root@stevo1 restrack-v2]# git log --abbrev=12 --pretty=format:'%h %ad %s' 2f08ee363fe0..
ad0d40dceeb9 Mon Feb 19 08:30:03 2018 -0800 RDMA/nldev: provide detailed PD information
a6dee1428bc9 Mon Feb 19 10:24:24 2018 -0800 mlx4_ib: zero out struct ib_pd when allocating
74dfc0aa2480 Mon Feb 19 08:22:11 2018 -0800 RDMA/nldev: provide detailed MR information
0dbbb2a638a5 Mon Feb 19 10:58:54 2018 -0800 mlx4_ib: set user mr attributes in struct ib_mr
bd9f59299fc3 Mon Feb 19 08:22:10 2018 -0800 iw_cxgb4: initialize ib_mr fields for user mrs
7317eccc7687 Mon Feb 19 08:22:00 2018 -0800 RDMA/nldev: provide detailed CQ information
28891e0ffb01 Mon Feb 19 08:16:34 2018 -0800 RDMA/nldev: provide detailed CM_ID information
ab41c34eda79 Mon Feb 19 08:16:33 2018 -0800 RDMA/CM: move rdma_id_private to cma_priv.h
43f56a109bc3 Mon Feb 19 09:24:16 2018 -0800 RDMA/restrack: clean up res_to_dev()

The commit dates look ok though:

[root@stevo1 restrack-v2]# git log --abbrev=12 --pretty=format:'%h %cd %s' 2f08ee363fe0..
ad0d40dceeb9 Mon Feb 19 11:02:30 2018 -0800 RDMA/nldev: provide detailed PD information
a6dee1428bc9 Mon Feb 19 11:02:29 2018 -0800 mlx4_ib: zero out struct ib_pd when allocating
74dfc0aa2480 Mon Feb 19 11:02:29 2018 -0800 RDMA/nldev: provide detailed MR information
0dbbb2a638a5 Mon Feb 19 10:58:54 2018 -0800 mlx4_ib: set user mr attributes in struct ib_mr
bd9f59299fc3 Mon Feb 19 09:29:51 2018 -0800 iw_cxgb4: initialize ib_mr fields for user mrs
7317eccc7687 Mon Feb 19 09:29:49 2018 -0800 RDMA/nldev: provide detailed CQ information
28891e0ffb01 Mon Feb 19 09:26:41 2018 -0800 RDMA/nldev: provide detailed CM_ID information
ab41c34eda79 Mon Feb 19 09:26:38 2018 -0800 RDMA/CM: move rdma_id_private to cma_priv.h
43f56a109bc3 Mon Feb 19 09:24:16 2018 -0800 RDMA/restrack: clean up res_to_dev()

So I need to fix my process and not screw up the author dates.  Sorry about this.

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux