RE: [PATCH v2 rdma-next 2/9] RDMA/CM: move rdma_id_private to cma_priv.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Mon, 2018-02-19 at 22:53 -0500, Doug Ledford wrote:
> > On Mon, 2018-02-19 at 16:11 -0700, Jason Gunthorpe wrote:
> > > On Mon, Feb 19, 2018 at 05:09:15PM -0600, Steve Wise wrote:
> > >
> > > > > And please check patchworks, there is something wrong with how you
> send
> > > > > patches they get wronly ordered and have wonky dates.. Makes them
> hard
> > > > > to apply..
> > > >
> > > > I'm sending them with sendmail.  I'll figure it out...
> > >
> > > So do I, I just have git-send-email call it for me :)
> > >
> > > [sendemail]
> > >         smtpserver = /usr/sbin/sendmail
> > > 	confirm = always
> > > 	from = Jason Gunthorpe <jgg@xxxxxxxx>
> > > 	envelopeSender = Jason Gunthorpe <jgg@xxxxxxxx>
> > > 	suppresscc = self
> > >
> > > Jason
> >
> > I think it's the size of the patch.  I've seen this before.  Big patches
> > can end up landing in patchworks out of order, and I think it's because
> > the mailman queues on vger simply send the files, so smaller patches,
> > even though queued later, can end up ahead of bigger patches because
> > they deliver to recipients faster.
> >
> 
> Ok, after looking, none of these patches are large enough to cause the
> effect I talked about.  It's normally things like 10,000 line binary
> blob patches that get obviously out of sequence.  Everything here is
> small enough I would expect it to deliver in order, so I don't know
> what's going on here except maybe the specific smtp server Steve is
> using might be reordering things?
> 
> There is another option, but it only applies to direct and list
> recipients such as myself and Jason.  I filter my incoming email to
> remove duplicates.  Sometimes the list email arrives first and sometimes
> the direct email arrives first.  Just depends.  Either way, they are all
> filtered to the same folder and de-duped (which means if you *really*
> want to get my attention, you email me without including a mailing
> list).
> 
> But, that's not it either.  Looking at this thread, the cover letter is
> from Steve at 2:15pm.  However, patch 2/9 is from Steve at 11:16am.  See
> for yourself:
> 
> Cover Letter headers:
> 
> Received: from mx1.redhat.com (ext-
> mx03.extmail.prod.ext.phx2.redhat.com
> [10.5.110.27])
>         by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DD2365620
>         for <dledford@xxxxxxxxxx>; Mon, 19 Feb 2018 19:17:38 +0000 (UTC)
> Received: from smtp.opengridcomputing.com (opengridcomputing.com
> [70.118.0.34])
>         (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
> bits))
>         (No client certificate requested)
>         by mx1.redhat.com (Postfix) with ESMTPS id 09AEB81127
>         for <dledford@xxxxxxxxxx>; Mon, 19 Feb 2018 19:17:37 +0000 (UTC)
> Received: by smtp.opengridcomputing.com (Postfix, from userid 503)
>         id 92A272B977; Mon, 19 Feb 2018 13:17:35 -0600 (CST)
> Message-id: <cover.1519067702.git.swise@xxxxxxxxxxxxxxxxxxxxx>
> From: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 19 Feb 2018 11:15:02 -0800 (02/19/2018 02:15:02 PM)
> Subject: [PATCH v2 rdma-next 0/9] cm_id, cq, mr, and pd resource
> tracking
> 
> Patch 2/9 headers:
> 
> Received: from mx1.redhat.com (ext-
> mx03.extmail.prod.ext.phx2.redhat.com
> [10.5.110.27])
>         by smtp.corp.redhat.com (Postfix) with ESMTPS id 636C260BE6
>         for <dledford@xxxxxxxxxx>; Mon, 19 Feb 2018 19:17:47 +0000 (UTC)
> Received: from smtp.opengridcomputing.com (opengridcomputing.com
> [70.118.0.34])
>         (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
> bits))
>         (No client certificate requested)
>         by mx1.redhat.com (Postfix) with ESMTPS id 7C26E80F9C
>         for <dledford@xxxxxxxxxx>; Mon, 19 Feb 2018 19:17:46 +0000 (UTC)
> Received: by smtp.opengridcomputing.com (Postfix, from userid 503)
>         id AAFBF2B9B8; Mon, 19 Feb 2018 13:17:45 -0600 (CST)
> Message-id:
> <ab41c34eda793654700ff4b2dce04782620e4ebc.1519067702.git.swi
> se@xxxxxxxxxxxxxxxxxxxxx>
> In-reply-to: <cover.1519067702.git.swise@xxxxxxxxxxxxxxxxxxxxx>
> References: <cover.1519067702.git.swise@xxxxxxxxxxxxxxxxxxxxx>
> From: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 19 Feb 2018 08:16:33 -0800 (02/19/2018 11:16:33 AM)
> Subject: [PATCH v2 rdma-next 2/9] RDMA/CM: move rdma_id_private to
> cma_priv.h
> 
> If you notice, once the messages make it to smtp.opengridcomputing.com,
> the timestamps are as you would expect and increment in reasonable steps
> , but the timestamps from Steve's machine are wonky.  So, there is
> something funky on Steve's machine with his sending timestamps.  Steve,
> are you taking a long time to edit files or something?  Or something
> else that would throw off the git send-email process?


Oh I think I know what's happening.  I created these patches on a machine that is in PST timezone, and the clock on the system might not even be setup correctly.   I use git format-patch for that.  I then pull the patches to Texas (CST timezone) and submit them to my email server via sendmail.  So the "Date: " in the patch is from the PST patch creation time, and the "Received: " times logged by ogc are CST.

Why is this confusing patchworks though?  If it uses the patch dates only or the received dates only, it should be in-order, I think.



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux