On Thu, Jan 11, 2018 at 09:56:22AM -0700, Jason Gunthorpe wrote:
> On Thu, Jan 11, 2018 at 08:05:37AM +0200, Leon Romanovsky wrote:
>
> > > If anything should be fixed here, it is to move the degradation closer
> > > to the actual copy_to_user.
> > >
> > > Why was it put here anyhow? I don't see a uapi boundary?
>
> Actually, looking again, in the morning, it seems placed OK. This is
> about as close to the copy_to_user as possible in this flow..
So, are you going to pick up?
>
> > As Parav wrote, it was added in commit 57520751445b ("IB/SA: Add OPA
> > path record type") and it looks like this sa_convert_path_ib_to_opa()
> > can be deleted, because there is the same conversion in ucma_query_path().
>
> ucma_path_query is OK, the sa_convert_path_opa_to_ib is directly before
> the copy_to_user.
>
> Jason
Attachment:
signature.asc
Description: PGP signature
