From: Parav Pandit <parav@xxxxxxxxxxxx>
Code is refactored to perform transport specific checks for OPA, IB,
RoCE to be done in core routine. Wherever possible, it is better to avoid
spreading transport specific code in multiple kernel modules.
Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx>
Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>
---
drivers/infiniband/core/cma.c | 11 ++++++++++-
drivers/infiniband/core/ucma.c | 9 +--------
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index f1e425da926d..68223bd56b53 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2522,14 +2522,23 @@ int rdma_set_ib_path(struct rdma_cm_id *id,
struct sa_path_rec *path_rec)
{
struct rdma_id_private *id_priv;
+ struct sa_path_rec *in_path_rec;
+ struct sa_path_rec opa;
int ret;
+ if (rdma_cap_opa_ah(id->device, id->port_num)) {
+ sa_convert_path_ib_to_opa(&opa, path_rec);
+ in_path_rec = &opa;
+ } else {
+ in_path_rec = path_rec;
+ }
+
id_priv = container_of(id, struct rdma_id_private, id);
if (!cma_comp_exch(id_priv, RDMA_CM_ADDR_RESOLVED,
RDMA_CM_ROUTE_RESOLVED))
return -EINVAL;
- id->route.path_rec = kmemdup(path_rec, sizeof(*path_rec),
+ id->route.path_rec = kmemdup(in_path_rec, sizeof(*in_path_rec),
GFP_KERNEL);
if (!id->route.path_rec) {
ret = -ENOMEM;
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index 6d32af27bac6..7b25226b608e 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1227,14 +1227,7 @@ static int ucma_set_ib_path(struct ucma_context *ctx,
sa_path.rec_type = SA_PATH_REC_TYPE_IB;
ib_sa_unpack_path(path_data->path_rec, &sa_path);
- if (rdma_cap_opa_ah(ctx->cm_id->device, ctx->cm_id->port_num)) {
- struct sa_path_rec opa;
-
- sa_convert_path_ib_to_opa(&opa, &sa_path);
- ret = rdma_set_ib_path(ctx->cm_id, &opa);
- } else {
- ret = rdma_set_ib_path(ctx->cm_id, &sa_path);
- }
+ ret = rdma_set_ib_path(ctx->cm_id, &sa_path);
if (ret)
return ret;
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
