On Thu, Dec 21, 2017 at 09:34:33AM -0700, Jason Gunthorpe wrote: > On Thu, Dec 21, 2017 at 03:00:34PM +0200, Leon Romanovsky wrote: > > On Wed, Dec 20, 2017 at 11:27:28AM -0800, Bryan Tan wrote: > > > BIT() should not be used in the UAPI header. Remove it. > > > > > > Signed-off-by: Bryan Tan <bryantan@xxxxxxxxxx> > > > include/uapi/rdma/vmw_pvrdma-abi.h | 12 ++++++------ > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > IMHO, it should go to -rc. > > Doug, Jason? > > I can't decide if any of the -abi.h changes should be for-rc material > or not.. > > The BIT() issue is being worked around in userspace today, so this > seems even less for-rc'y? > > I'm leaning toward 'not' as we can and do cherry pick a for-next > uapi header into rdma-core, so there isn't really an actual reason to > put changes to those headers into for-rc? > > Thoughts? I think that UAPI should be fixed immediately without any relation to number of users (in our case one), but simple include of that -abi.h will cause to application breakage. Thanks > > Jason
Attachment:
signature.asc
Description: PGP signature
