On Wed, Dec 20, 2017 at 11:27:28AM -0800, Bryan Tan wrote: > BIT() should not be used in the UAPI header. Remove it. > > Signed-off-by: Bryan Tan <bryantan@xxxxxxxxxx> > include/uapi/rdma/vmw_pvrdma-abi.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/rdma/vmw_pvrdma-abi.h b/include/uapi/rdma/vmw_pvrdma-abi.h > index 4007cac..02ca0d0 100644 > +++ b/include/uapi/rdma/vmw_pvrdma-abi.h > @@ -52,14 +52,14 @@ > #define PVRDMA_UVERBS_ABI_VERSION 3 /* ABI Version. */ > #define PVRDMA_UAR_HANDLE_MASK 0x00FFFFFF /* Bottom 24 bits. */ > #define PVRDMA_UAR_QP_OFFSET 0 /* QP doorbell. */ > -#define PVRDMA_UAR_QP_SEND BIT(30) /* Send bit. */ > -#define PVRDMA_UAR_QP_RECV BIT(31) /* Recv bit. */ > +#define PVRDMA_UAR_QP_SEND (1 << 30) /* Send bit. */ > +#define PVRDMA_UAR_QP_RECV (1 << 31) /* Recv bit. */ I changed the '1<<31' to '1UL<<31' when I applied this to for-next, the constants should be unsigned to avoid problems with sign extensions on the high bit. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
