On Thu, Jul 13, 2017 at 04:39:35PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> [59/189] Building C object providers/bnxt_re/CMakeFiles/bnxt_re-rdmav2.dir/verbs.c.o
> ../providers/bnxt_re/verbs.c: In function ‘bnxt_re_post_send’:
> ../providers/bnxt_re/verbs.c:1222:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
> hdr->key_immd = htole32(be32toh(wr->imm_data));
> ^
> ../providers/bnxt_re/verbs.c:1223:3: note: here
> case IBV_WR_SEND:
> ^~~~
> ../providers/bnxt_re/verbs.c:1232:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
> hdr->key_immd = htole32(be32toh(wr->imm_data));
> ^
> ../providers/bnxt_re/verbs.c:1233:3: note: here
> case IBV_WR_RDMA_WRITE:
Can you follow the same approach as I used in
commit 47cd2efcd4cd416ead0a1a48153aa27a2e178ce5
Author: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
Date: Tue Jan 31 14:55:50 2017 -0700
Annotate correct switch fall throughs with SWITCH_FALLTHROUGH
Or convert those cases to this approach?
> * LE platform be32toh will do the job.
> */
> hdr->key_immd = htole32(be32toh(wr->imm_data));
> + /* FALLTHROUGH */
Use the SWITCH_FALLTHROUGH; macro
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
