On Thu, 2017-07-13 at 11:51 -0600, Jason Gunthorpe wrote: > Can you follow the same approach as I used in > > commit 47cd2efcd4cd416ead0a1a48153aa27a2e178ce5 > Author: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> > Date: Tue Jan 31 14:55:50 2017 -0700 > > Annotate correct switch fall throughs with SWITCH_FALLTHROUGH > > Or convert those cases to this approach? > > > * LE platform be32toh will do the job. > > */ > > hdr->key_immd = htole32(be32toh(wr->imm_data)); > > + /* FALLTHROUGH */ > > Use the SWITCH_FALLTHROUGH; macro Hello Jason, Both Coverity and gcc 7 understand fall-through comments. Do we really need a macro to annotate fall-through in switch statements? Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html