On Thu, Jul 13, 2017 at 03:06:11PM +0000, Bart Van Assche wrote: > On Thu, 2017-07-13 at 16:39 +0300, Leon Romanovsky wrote: > > diff --git a/providers/bnxt_re/verbs.c b/providers/bnxt_re/verbs.c > > index 1fe79671..da0fe733 100644 > > --- a/providers/bnxt_re/verbs.c > > +++ b/providers/bnxt_re/verbs.c > > @@ -1220,6 +1220,7 @@ int bnxt_re_post_send(struct ibv_qp *ibvqp, struct ibv_send_wr *wr, > > * LE platform be32toh will do the job. > > */ > > hdr->key_immd = htole32(be32toh(wr->imm_data)); > > + /* FALLTHROUGH */ > > Hello Leon, > > In other rdma-core source files the annotation "/* fall through */" is used. > See also the output of git grep -nHi '/\* *fall[ -]*through'. Should we ensure > that these annotations are consistent in the rdma-core source tree? Yes, better to have consistency. I took this "FALLTHROUGH" from kernel source. I'll resend. Thanks > > Bart.
Attachment:
signature.asc
Description: PGP signature
