On Wed, Jun 28, 2017 at 10:19:03AM -0600, Jason Gunthorpe wrote: > On Wed, Jun 28, 2017 at 07:16:16PM +0300, Leon Romanovsky wrote: > > On Wed, Jun 28, 2017 at 10:05:13AM -0600, Jason Gunthorpe wrote: > > > On Wed, Jun 28, 2017 at 04:34:44PM +0300, Leon Romanovsky wrote: > > > > + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_LID, attr.lid)) > > > > + return -EMSGSIZE; > > > > + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_SM_LID, attr.sm_lid)) > > > > + return -EMSGSIZE; > > > > > > Is this careful to only stuff attributes if they actuall exists? Eg > > > these should not be present for iwarp/roce/etc > > > > > > Same comment for all attributes. Only present if they are valid. > > > > It will be zero if it is not exist, but you are right it is better to > > avoid to fill unneeded fields. > > Not existing is the netlink way. Same comment for everything > attributes. Many of the guids do not apply to iwarp, IIRC.. I got it, this is why I prefer to have basic RDMAtool with minimal prints (device name + caps) be accepted and only after that start work on every field in serial manner. Thanks > > Jason
Attachment:
signature.asc
Description: PGP signature
