On Wed, Jun 28, 2017 at 04:34:44PM +0300, Leon Romanovsky wrote: > + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_LID, attr.lid)) > + return -EMSGSIZE; > + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_SM_LID, attr.sm_lid)) > + return -EMSGSIZE; Is this careful to only stuff attributes if they actuall exists? Eg these should not be present for iwarp/roce/etc Same comment for all attributes. Only present if they are valid. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
