RE: [PATCH] IB/iser: Handle lack of memory management extentions correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hi Mike, for the patch itself, it addresses a bug so,
> 
> Acked-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> 
> But,
> 
> As for not having any max pages for FMR it's really annoying.
> 
> What do you think about exposing max_fast_reg_page_list_len to
> limit also for FMRs? We can also rename it to max_reg_page_list_len
> to get rid of the FRWR association.
> 
> Thoughts?

I have no issue with your proposal, but I would rather get this fixed and adjust the API with an additional fix.   I suspect we probably want to mark this fix stable.

I did audit the kernel ULPs for FMR vs. FRMR usage and the only one that looked at max_fast_reg_page_list_len unconditionally was iser.

Thomas, can you verify this patch and reply with a Tested-by:

Meanwhile, I will audit kernel providers for which ones besides qib do not support the extensions and FMR.

Mike
��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux